Avoid padding CAN_FD_MESSAGE_64 objects to 4 bytes#628
Merged
christiansandberg merged 3 commits intohardbyte:developfrom Jun 23, 2019
Merged
Avoid padding CAN_FD_MESSAGE_64 objects to 4 bytes#628christiansandberg merged 3 commits intohardbyte:developfrom
christiansandberg merged 3 commits intohardbyte:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
===========================================
+ Coverage 63.91% 63.94% +0.02%
===========================================
Files 63 63
Lines 5623 5624 +1
===========================================
+ Hits 3594 3596 +2
+ Misses 2029 2028 -1 |
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
===========================================
+ Coverage 63.91% 63.94% +0.02%
===========================================
Files 63 63
Lines 5623 5624 +1
===========================================
+ Hits 3594 3596 +2
+ Misses 2029 2028 -1 |
Codecov Report
@@ Coverage Diff @@
## develop #628 +/- ##
===========================================
+ Coverage 63.91% 63.94% +0.02%
===========================================
Files 63 63
Lines 5623 5624 +1
===========================================
+ Hits 3594 3596 +2
+ Misses 2029 2028 -1 |
christiansandberg
approved these changes
Jun 23, 2019
Collaborator
christiansandberg
left a comment
christiansandberg
left a comment
There was a problem hiding this comment.
I would probably refactor the code just a little bit to avoid calculating the padding twice.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the BLF files with CAN_FD_MESSAGE_64 objects that I have (unfortunately none that I can share at this point), objects of that type are not padded to multiples of four bytes. This also agrees with the implementation in vector_blf.